A signed build still rewrites capsules/BLOCK_MAP.md's Signed column #183

New Issue

2026-11-11T21:34:14Z

rajames commented

2026-11-11 21:34:14 +00:00

Found

Since 90c5c140 (#145) BLOCK_MAP.md has no timestamp and an unsigned build leaves it as committed. tools/mkcapsule.c (~line 782) writes the Signed column as yes/no with --sign-key and n/a without, plus a note when unsigned. The committed copy is an unsigned build's, so a signed build (CI's, or one with SIGN_KEY) still dirties the tree; the put-backs keep BLOCK_MAP.md for that reason.

Done when

Decided: the manifest drops the Signed column (signing shown elsewhere), the committed copy is a signed build's, or it stays and the put-backs say why

🤖 Filed with Claude Code -- the code review of 2026-11-11, at 4d42d25c (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

### Found Since `90c5c140` (#145) BLOCK_MAP.md has no timestamp and an unsigned build leaves it as committed. `tools/mkcapsule.c` (~line 782) writes the Signed column as `yes`/`no` with `--sign-key` and `n/a` without, plus a note when unsigned. The committed copy is an unsigned build's, so a signed build (CI's, or one with SIGN_KEY) still dirties the tree; the put-backs keep BLOCK_MAP.md for that reason. ### Done when - [ ] Decided: the manifest drops the Signed column (signing shown elsewhere), the committed copy is a signed build's, or it stays and the put-backs say why 🤖 Filed with [Claude Code](https://claude.com/claude-code) -- the code review of 2026-11-11, at `4d42d25c` (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

rajames added the

labels 2026-11-11 21:34:15 +00:00

Sign in to join this conversation.