logs: the nightly's fe25519 sanitizer failure, reproduced without the signing key

fe25519_carry shifts a negative carry left (fe25519.c:31, and :35),
undefined in C99; CI's signed capsules reach it in san-mesh-boot.
Reported, not fixed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017RzZgrf7V7Zk2iczBXDRbm
This commit is contained in:
Claude
2026-11-20 12:54:08 +00:00
parent f7769c0e93
commit 40e9773885
4 changed files with 34 additions and 0 deletions
+16
View File
@@ -0,0 +1,16 @@
The nightly's v4-checks failure of 2026-11-20 (run 333, job 923, on master fdf9c194), reproduced
without the capsule-signing key.
CI: san-mesh-boot: kernel/src/crypto/fe25519.c:31:26: runtime error: left shift of negative value -1
Here: repro.c, built with the sanitize gate's flags (-O1 -fsanitize=address,undefined
-fno-sanitize-recover=all) against kernel/src/crypto/fe25519.c alone: run.txt, the same line.
Cause: fe25519_carry computes c = v[i] >> 51 and then v[i] -= c << 51. After fe25519_sub, a limb is
negative, c is -1, and a left shift of a negative value is undefined in C99. The comment says the
code "works for negative limbs too (arithmetic shift preserves sign)", which holds for the right
shift, not the left. Line 35 (limb 4) has the same form.
Why locally the sanitize gate passes: with no signing key the capsules are unsigned, and the mesh
boot never verifies an Ed25519 signature, so this code does not run there. CI has the key.
Not fixed (reported to Captain Bob).
View File
+15
View File
@@ -0,0 +1,15 @@
/* Reproduces the nightly's san-mesh-boot failure (run 333, 2026-11-20) without the signing key:
* fe25519_sub(0, 1) leaves limb 0 at -1, and fe25519_carry shifts the carry of -1 left by 51. */
#include "starkernel/fe25519.h"
#include <stdio.h>
int main(void)
{
fe25519 zero, one, r;
fe25519_0(&zero);
fe25519_1(&one);
printf("fe25519_sub(0, 1) ...\n");
fflush(stdout);
fe25519_sub(&r, &zero, &one);
printf("done: v[0]=%lld\n", (long long)r.v[0]);
return 0;
}
+3
View File
@@ -0,0 +1,3 @@
fe25519_sub(0, 1) ...
kernel/src/crypto/fe25519.c:31:26: runtime error: left shift of negative value -1
exit 1