sk_v4_idle allocated a controller's slot array again whenever max_slots + 1 was more than it held -- the old array dropped, neither copied nor freed -- while the identity code holds pointers into it (g_offered, g_spare, g_pending_real, g_real_drive, g_zuse_dev). Its two slot loops then ran to max_slots whatever the array held. sk_v4_slots_get() (kernel/src/v4/sk_v4_slots.c): allocated once, zeroed, at the size first asked for; never replaced; the slots that may be used are those it has. sk_v4_idle uses it, and its loops stop at the array's end. kernel/tests/test_sk_v4_slots.c, kmalloc_aligned faked, seen to fail first against the allocation as it was (4 failures: replaced when more were asked for, 17 said usable where 9 existed, a held pointer left behind, an allocation for 0); now 6 checks, 0 failures. Built for amd64, aarch64, riscv64; latent today (max_slots does not grow), so the boots show no change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RzZgrf7V7Zk2iczBXDRbm
12 lines
763 BLFS
Plaintext
12 lines
763 BLFS
Plaintext
=== test_sk_v4_slots against the slots as sk_v4_idle kept them (replaced when more were wanted)
|
|
test_sk_v4_slots
|
|
FAIL /home/user/LithosAnanke/kernel/tests/test_sk_v4_slots.c:35: #178: asked for more: the same array, not replaced (allocations 2)
|
|
FAIL /home/user/LithosAnanke/kernel/tests/test_sk_v4_slots.c:36: #178: and only the 9 slots it has may be used, not 17 (n 17)
|
|
FAIL /home/user/LithosAnanke/kernel/tests/test_sk_v4_slots.c:37: #178: a pointer held into a slot is still the slot, with the drive in it
|
|
FAIL /home/user/LithosAnanke/kernel/tests/test_sk_v4_slots.c:43: 0 slots wanted: none to use, nothing allocated
|
|
6 checks, 4 failures
|
|
make: *** [Makefile:39: run-test_sk_v4_slots] Error 1
|
|
=== test_sk_v4_slots now
|
|
test_sk_v4_slots
|
|
6 checks, 0 failures
|