Claude
b0038376a7
Captain Bob, 2026-11-12: "Yes, reject unsigned builds". acceptance.yml's "The capsule-signing key" step warned when CAPSULE_SIGN_KEY was missing and the PR's acceptance went on, unsigned. Now it is an ::error:: and the step fails, so the gate does too. A local or protocol build may still be unsigned (kernel/Makefile, v4/Makefile): the refusal is the gate's. build.yml, nightly.yml and release.yml still warn -- release.yml is Captain Bob's to rule. scripts/test_acceptance_signing.sh takes the step from acceptance.yml as CI runs it and runs it with and without a key. Against the workflow as it was: the unsigned case passed, no error -- 2 failures. Now: no key fails with an ::error::, a key is handed to the build as SIGN_KEY. logs/20261112-185739/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RzZgrf7V7Zk2iczBXDRbm
83 lines
3.6 KiB
YAML
83 lines
3.6 KiB
YAML
# The acceptance protocol, as the gate on every pull request into master (Captain Bob, 2026-11-06:
|
|
# "failures should not be allowed to be merged to master"). It is .claude/CLAUDE.md's protocol,
|
|
# run by the same stages a developer and the nightly run (scripts/nightly.sh), in its order, one
|
|
# QEMU at a time:
|
|
#
|
|
# amd64, aarch64, riscv64 to [zuse@Hera] ok>, POST: PASSED, `3 4 + .` -> 7 ok
|
|
# the PC stick loaded high the same; and the three architectures' dict_hash agree
|
|
# the 32-bit build make -C v4 test-32, 0 failures
|
|
#
|
|
# master's branch protection requires this check to pass before a PR merges. The serial logs and
|
|
# DoE CSVs are kept as the run's artifacts, pass or fail.
|
|
name: Acceptance
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [master]
|
|
types: [opened, synchronize, reopened]
|
|
workflow_dispatch:
|
|
|
|
# No concurrency group (Captain Bob, 2026-11-11, #140: "It should be global"). The one runner
|
|
# (starshipos-vps) has capacity 1, so every job of every workflow waits its turn in Gitea's queue
|
|
# and none is cancelled; a runner-image rebuild still blocks the rest (2026-11-07). A shared
|
|
# concurrency group kept only one waiting run, and each run that joined cancelled it.
|
|
|
|
jobs:
|
|
acceptance:
|
|
name: Acceptance
|
|
runs-on: ubuntu-latest
|
|
container:
|
|
image: gitea.starshipos-f18.org/rajames/lithosananke-runner:4f675c8b75b2 # ci/runner-image (#120)
|
|
credentials: # the registry refuses anonymous pulls
|
|
username: rajames
|
|
password: ${{ secrets.PACKAGES_TOKEN }}
|
|
timeout-minutes: 120
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0 # the SBOM's version is git describe
|
|
lfs: false # only the logs and DoE CSVs are in LFS; the build needs neither
|
|
|
|
# The developer protocol's evidence first (#135): the PR's head carries a passing
|
|
# logs/<TS>/PROTOCOL.md for its own tree (scripts/nightly.sh protocol, run by hand), or it is
|
|
# refused here, before the boots. The head, not the merge commit the checkout made.
|
|
- name: The developer protocol's evidence
|
|
run: scripts/check_protocol.sh "${{ github.event.pull_request.head.sha || 'HEAD' }}"
|
|
|
|
# The gate into master refuses an unsigned build (#174; Captain Bob, 2026-11-12: "Yes, reject
|
|
# unsigned builds"). It warned and went on. scripts/test_acceptance_signing.sh runs this step.
|
|
- name: The capsule-signing key
|
|
env:
|
|
KEY: ${{ secrets.CAPSULE_SIGN_KEY }}
|
|
run: | # ci/pki/make-ca.sh; kernel/Makefile signs with SIGN_KEY
|
|
if [ -n "$KEY" ]; then
|
|
f="${RUNNER_TEMP:-/tmp}/capsule-signing.key"
|
|
(umask 077; printf '%s\n' "$KEY" > "$f")
|
|
echo "SIGN_KEY=$f" >> "$GITHUB_ENV"; echo "The capsules will be signed."
|
|
else
|
|
echo "::error::No CAPSULE_SIGN_KEY secret: the gate into master does not accept an unsigned build."
|
|
exit 1
|
|
fi
|
|
|
|
- name: Acceptance amd64
|
|
run: scripts/nightly.sh accept amd64
|
|
- name: Acceptance aarch64
|
|
run: scripts/nightly.sh accept aarch64
|
|
- name: Acceptance riscv64
|
|
run: scripts/nightly.sh accept riscv64
|
|
- name: Acceptance PC stick loaded high
|
|
run: scripts/nightly.sh accept stick-high
|
|
- name: Acceptance 32-bit build
|
|
run: scripts/nightly.sh test-32
|
|
|
|
- name: Keep the logs and DoE CSVs
|
|
if: always()
|
|
uses: actions/upload-artifact@v3
|
|
with:
|
|
name: acceptance-logs-${{ github.run_number }}
|
|
path: |
|
|
logs/
|
|
experiments/bare_metal/runs/
|
|
build/nightly/accept-*.txt
|
|
build/nightly/test-32.txt
|