Claude
41f8648dd9
sk_v4_idle allocated a controller's slot array again whenever max_slots + 1 was more than it held -- the old array dropped, neither copied nor freed -- while the identity code holds pointers into it (g_offered, g_spare, g_pending_real, g_real_drive, g_zuse_dev). Its two slot loops then ran to max_slots whatever the array held. sk_v4_slots_get() (kernel/src/v4/sk_v4_slots.c): allocated once, zeroed, at the size first asked for; never replaced; the slots that may be used are those it has. sk_v4_idle uses it, and its loops stop at the array's end. kernel/tests/test_sk_v4_slots.c, kmalloc_aligned faked, seen to fail first against the allocation as it was (4 failures: replaced when more were asked for, 17 said usable where 9 existed, a held pointer left behind, an allocation for 0); now 6 checks, 0 failures. Built for amd64, aarch64, riscv64; latent today (max_slots does not grow), so the boots show no change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RzZgrf7V7Zk2iczBXDRbm
43 lines
1.6 KiB
Makefile
43 lines
1.6 KiB
Makefile
# SPDX-License-Identifier: LicenseRef-Starship-1.0
|
|
# Copyright (c) 2023-2026 Robert A. James
|
|
#
|
|
# The kernel host tests (docs/v4.0.0/plans/2026-11-12-kernel-host-tests.md): each test_<unit>.c
|
|
# built on the host with the kernel source file(s) it tests and the fakes, nothing else of the
|
|
# kernel, and run.
|
|
#
|
|
# make -C kernel/tests test build and run them all; fails if any check fails
|
|
# make -C kernel/tests run-test_gpt
|
|
#
|
|
# A test's sources are SRC_<test>; give another on the command line to run the same test against
|
|
# it (how a test is seen to fail against the code before a fix):
|
|
# make -C kernel/tests run-test_gpt SRC_test_gpt=/path/to/old/gpt.c
|
|
|
|
HERE := $(abspath $(dir $(lastword $(MAKEFILE_LIST))))
|
|
ROOT := $(abspath $(HERE)/../..)
|
|
BUILD := $(ROOT)/build/kernel-tests
|
|
CC ?= cc
|
|
CFLAGS := -std=c99 -Wall -Wextra -Werror -O2 -g -I$(HERE) -I$(ROOT)/kernel/include \
|
|
-I$(ROOT)/kernel/include/starkernel -I$(ROOT)/v3/include
|
|
|
|
TESTS := test_gpt test_usb_config test_sk_v4_stop test_sk_v4_slots
|
|
SRC_test_sk_v4_slots := $(ROOT)/kernel/src/v4/sk_v4_slots.c
|
|
SRC_test_sk_v4_stop := $(ROOT)/kernel/src/v4/sk_v4_stop.c
|
|
SRC_test_gpt := $(ROOT)/kernel/src/gpt.c
|
|
SRC_test_usb_config := $(ROOT)/kernel/src/usb/usb_config.c
|
|
|
|
define TEST_RULE
|
|
$(BUILD)/$(1): $(HERE)/$(1).c $(HERE)/fakes.c $(HERE)/fakes.h $(HERE)/harness.h $$(SRC_$(1))
|
|
@mkdir -p $(BUILD)
|
|
$(CC) $(CFLAGS) $(HERE)/$(1).c $(HERE)/fakes.c $$(SRC_$(1)) -o $$@
|
|
|
|
.PHONY: run-$(1)
|
|
run-$(1): $(BUILD)/$(1)
|
|
@echo "$(1)"
|
|
@$(BUILD)/$(1)
|
|
endef
|
|
$(foreach t,$(TESTS),$(eval $(call TEST_RULE,$(t))))
|
|
|
|
.PHONY: test
|
|
test: $(addprefix run-,$(TESTS))
|
|
@echo "all kernel host tests passed"
|