sk_v4_grow.c's dev_rw4k computes 1 KiB block numbers as (uint32_t)devblock * 4, which wraps past 4 TiB; Artemis is capped at 256 GiB (STICK_ARTEMIS_CAP_GIB, kernel/Makefile), so it is latent -- but nothing said so where the cast is. Now a compile-time check there (the C99 negative-array pattern the tree uses): a cap past 4 TiB stops the build, and a cap not defined at all is an #error, not a skipped check. gpt.c's casts are bounded by the disk's own size, itself a 32-bit count of 1 KiB blocks, checked before each: each now says so. kernel/tests' check_cap, seen to fail first (a 4096 GiB cap built); now 3 checks, 0 failures -- 256 GiB builds, 4096 GiB and none refused. Built for amd64, aarch64, riscv64. The plan's increments 2 and 3 marked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017RzZgrf7V7Zk2iczBXDRbm
8 lines
248 BLFS
Plaintext
8 lines
248 BLFS
Plaintext
=== check_cap against sk_v4_grow.c as it was
|
|
check_cap
|
|
FAIL #182: a 4096 GiB cap builds -- its block numbers do not fit 32 bits, and nothing stops it
|
|
make: *** [Makefile:50: run-check_cap] Error 1
|
|
=== check_cap now
|
|
check_cap
|
|
3 checks, 0 failures
|