v4: comments that read as unfinished or say what the code no longer does #181

New Issue

2026-11-11T21:34:06Z

rajames commented

2026-11-11 21:34:06 +00:00

Found

v4/src/heat.c:28, 33 call_index(): "here we hash-mod or just take low bits?", "ignore for now? Or clamp?" -- an unfinished thought in a comment, against the standing rule of no TODO-shaped comments (ENGINE step 4 Part A1 plans to remove call[] altogether).
v4/include/v4/stack.h:20 "There is no overflow or underflow detection, and there never will be" and v4/src/stack.c:27-30 -- D-16 added the guards; stack.c also hardcodes "mod 8" while the ring size is a build parameter (DATASHEET section 13 item 4).

Done when

Each comment states what the code does now

🤖 Filed with Claude Code -- the code review of 2026-11-11, at 4d42d25c (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

### Found - `v4/src/heat.c:28, 33` `call_index()`: "here we hash-mod or just take low bits?", "ignore for now? Or clamp?" -- an unfinished thought in a comment, against the standing rule of no TODO-shaped comments (ENGINE step 4 Part A1 plans to remove `call[]` altogether). - `v4/include/v4/stack.h:20` "There is no overflow or underflow detection, and there never will be" and `v4/src/stack.c:27-30` -- D-16 added the guards; `stack.c` also hardcodes "mod 8" while the ring size is a build parameter (DATASHEET section 13 item 4). ### Done when - [ ] Each comment states what the code does now 🤖 Filed with [Claude Code](https://claude.com/claude-code) -- the code review of 2026-11-11, at `4d42d25c` (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

rajames added the area/v4

labels 2026-11-11 21:34:06 +00:00

Sign in to join this conversation.