boot.c: a line is reported done after 4096 steps even if the node has not settled #175

New Issue

2026-11-11T21:33:20Z

rajames commented

2026-11-11 21:33:20 +00:00

Found

v4/system/boot.c:253: when the text ends, for (i = 0; i < 4096u && !v4_node_doing(n) && !n->stopped && !n->asking; i++) boot_exec(b); then returns the line's result. If the node has not settled in 4096 steps the line is reported done anyway, and nothing says so -- a bounded but silent cut-off.

Done when

Either the bound is shown sufficient (and the reason written beside it) or reaching it is reported (an error, or STOPPED)

🤖 Filed with Claude Code -- the code review of 2026-11-11, at 4d42d25c (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

### Found `v4/system/boot.c:253`: when the text ends, `for (i = 0; i < 4096u && !v4_node_doing(n) && !n->stopped && !n->asking; i++) boot_exec(b);` then returns the line's result. If the node has not settled in 4096 steps the line is reported done anyway, and nothing says so -- a bounded but silent cut-off. ### Done when - [ ] Either the bound is shown sufficient (and the reason written beside it) or reaching it is reported (an error, or STOPPED) 🤖 Filed with [Claude Code](https://claude.com/claude-code) -- the code review of 2026-11-11, at `4d42d25c` (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

rajames added the area/v4

labels 2026-11-11 21:33:22 +00:00

Sign in to join this conversation.