Acceptance does not assert POST's test count #173

Open
opened 2026-11-11 21:32:53 +00:00 by rajames · 0 comments
Owner

Found

scripts/qemu_session.py checks POST: PASSED (and PARITY:V4_POST ... fail=0 only in the stick_v3 mode). A POST that silently lost cases would still pass. CLAUDE.md: tests=538 (the count grows with v4's POST).

Done when

  • Decided: a floor (the last accepted count, kept in the tree and raised with POST), or accept it as is and say so

🤖 Filed with Claude Code -- the code review of 2026-11-11, at 4d42d25c (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

### Found `scripts/qemu_session.py` checks `POST: PASSED` (and `PARITY:V4_POST ... fail=0` only in the `stick_v3` mode). A POST that silently lost cases would still pass. CLAUDE.md: `tests=538 (the count grows with v4's POST)`. ### Done when - [ ] Decided: a floor (the last accepted count, kept in the tree and raised with POST), or accept it as is and say so 🤖 Filed with [Claude Code](https://claude.com/claude-code) -- the code review of 2026-11-11, at `4d42d25c` (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.
rajames added the
status
backlog
kind
ci
priority
nice
labels 2026-11-11 21:32:54 +00:00
Sign in to join this conversation.