nightly.sh: the dict_hash agreement passes with fewer than three hashes #172

New Issue

2026-11-11T21:32:44Z

rajames commented

2026-11-11 21:32:44 +00:00

Found

scripts/nightly.sh (stick-high stage, ~line 113) collects the three architectures' dict_hash with sort -u (line 117) and passes when exactly one distinct value appears. An architecture whose log has no PARITY:V4_SYSTEM line, or whose accept-<arch>.txt has no LOG: line, contributes nothing, and the check still passes on the other two. Today each architecture's own stage would have failed first, so this is a second check that does not hold on its own.

Done when

The check counts three hashes, one per architecture, and fails with which one is missing

🤖 Filed with Claude Code -- the code review of 2026-11-11, at 4d42d25c (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

### Found `scripts/nightly.sh` (stick-high stage, ~line 113) collects the three architectures' `dict_hash` with `sort -u` (line 117) and passes when exactly one distinct value appears. An architecture whose log has no `PARITY:V4_SYSTEM` line, or whose `accept-<arch>.txt` has no `LOG:` line, contributes nothing, and the check still passes on the other two. Today each architecture's own stage would have failed first, so this is a second check that does not hold on its own. ### Done when - [ ] The check counts three hashes, one per architecture, and fails with which one is missing 🤖 Filed with [Claude Code](https://claude.com/claude-code) -- the code review of 2026-11-11, at `4d42d25c` (Captain Bob, 2026-11-11: "File the review findings as issues"). Read, not run: each is to be confirmed by a test written first and seen to fail.

rajames added the

labels 2026-11-11 21:32:46 +00:00

Sign in to join this conversation.