Fix out-of-bounds stack pushes/pops in four vendored word files (found during S-1a)

Browse Source

physics_freeze_words.c, dictionary_heat_diagnostic_words.c,
physics_diagnostic_words.c, physics_benchmark_words.c treated dsp as a
count (data_stack[dsp++] push, data_stack[--dsp] pop) while the VM's dsp
is the top index. On an empty stack a push wrote data_stack[-1], 8 bytes
before the VM struct -- POST's DECAY-RATE@ test did it every boot (on
aarch64 it hit parity.c's counter, elsewhere the POST block RAM tail).
All 28 sites now use vm_pop/vm_push; four one-item guards fixed (dsp<0).

Evidence on amd64/aarch64/riscv64: bytes before the VM struct unchanged
across POST; DECAY-RATE@ leaves 1 item; LOOKUP-STRATEGY! now works;
G interleave, precedence, console under load, relay 3, dict_hash unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

...

This commit is contained in:

Robert Allan James

2026-09-24 11:54:14 -04:00

co-authored by Claude Opus 5.5

parent d6c90a6839

commit 9bf2e8ec95

18 changed files with 60436 additions and 33 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

logs/20260924-104424/aarch64/qemu-aarch64-20260924-104424.log

+10918

File diff suppressed because it is too large Load Diff

logs/20260924-105120/aarch64/qemu-aarch64-20260924-105120.log

+10920

File diff suppressed because it is too large Load Diff

logs/20260924-105729/aarch64/qemu-aarch64-20260924-105729.log

+10924

File diff suppressed because it is too large Load Diff

logs/20260924-111124/amd64/qemu-amd64-20260924-111124.log

+9186

File diff suppressed because it is too large Load Diff

logs/20260924-112508/aarch64/qemu-aarch64-20260924-112508.log

+9158

File diff suppressed because it is too large Load Diff

logs/20260924-113949/riscv64/qemu-riscv64-20260924-113949.log

+9239

File diff suppressed because it is too large Load Diff