admin/LithosAnanake
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(kernel): a GPT disk with a bad header, or an unreadable first block, is not used

Browse Source 
The increment 2 final review's minors 1-4 (Captain Bob, 2026-10-27: "fix 1-4"):
1. A protective MBR with no "EFI PART" header is GPT_BAD, not GPT_NONE: the
   MBR says it is a GPT disk, and a GPT disk is never attached whole.
2. A disk whose block 0 cannot be read is GPT_EIO: "GPT: a USB drive could
   not be read -- not used", nothing attached (it was read raw, attached
   whole, and a raw Zuse drive behind it logged her in).
3. The entry array's LBA is checked against the disk's size directly.
4. gpt_bad_entries: the entry array changed, the header valid -- refused.
Harness modes gpt_no_header, gpt_read_error (blkdebug EIO on sector 0),
gpt_bad_entries. The plan carries the amendment.

Red (amd64): gpt_no_header 070335, gpt_read_error 070717 FAIL;
gpt_bad_entries 070048 PASS (existing check, now pinned). Green: every GPT
mode on amd64 071113-072933; gpt_zuse, gpt_read_error, gpt_no_header on
aarch64 073222-074047 and riscv64 074526-075535; the identity gate's and
increment 1's sessions 080036-082345, emergency 083130 (082635 was run
without EMERGENCY_CONSOLE_ENABLED=1 -- a harness invocation error).
Accepted: suite EXIT 0; 093121, 093352, 093750, POST 538/538, dict_hash
0xfec8c47cfc6f437f; test-32, 0 failures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rajames
2026-10-27 12:17:00 -04:00
co-authored by Claude Opus 5.5
parent f612bb37a9
commit 2e71f7aa0d
65 changed files with 4910 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/v4.0.0/plans/2026-10-26-stick-2-gpt-reader.md
+7
View File
@@ -99,6 +99,13 @@ on the raw device:
- `GPT_OK` with no StarshipOS partition: nothing attached, no identity check, no message.
- `GPT_BAD`: "GPT: a USB drive has a damaged partition table -- not used"; nothing attached.
- `GPT_NONE`: exactly today's raw path.
**Amended (Captain Bob, 2026-10-27, after the final review: "fix 1-4"):** a disk with a protective MBR
but no `"EFI PART"` header is `GPT_BAD`, not `GPT_NONE` -- the MBR already says it is a GPT disk, and
a GPT disk is never attached whole. A disk whose block 0 cannot be read is `GPT_EIO` (3): "GPT: a USB
drive could not be read -- not used", nothing attached. The entry array's LBA is checked against the
disk's size directly. Pinned by `gpt_no_header`, `gpt_read_error` and `gpt_bad_entries` (the entry
array's CRC, the header intact).
- On detach (`sk_v4_drive_left`, called with the raw slot): if that slot has an open partition
device, it is the partition device that is detached from the block subsystem and compared with
Zuse's; the raw device otherwise, as today. A slot that was never attached detaches nothing.